Isthmus: L1BlockInfoTx with Operator Fees

[yuwen01]

Overview

Updates the L1BlockInfoHolocene in op-alloy-protocol to include the new operator fee scalar and operator fee constant.

Additional Context

Design Doc
Spec.

[mattsse]

this looks correct to me,

pending @refcell sanity check

[refcell]

Isthmus is a different hardfork than Holocene. We'll need to add an entirely new L1BlockInfo type for Isthmus.

This should be done by:

• Leaving holocene types unchanged.
• Introducing a new variant in the L1BlockInfo enum called Isthmus that wraps a new L1BlockInfoIsthmus struct.
• Add a is_isthmus_active method to the RollupConfig with isthmus_time field.
• Add the operator fee parsing inside try_new when creating a new L1BlockInfoTx behind a if rollup_config.is_isthmus_active(l2_block_time) branch above the holocene check since it follows the holocene hardfork.

[yuwen01]

Sorry for the miscommunication -- since this feature is almost ready, I have verbal confirmation from tynes that it's very likely to be included in the Holocene hardfork. I'll update the spec shortly.

[refcell]

Sorry for the miscommunication -- since this feature is almost ready, I have verbal confirmation from tynes that it's very likely to be included in the Holocene hardfork. I'll update the spec shortly.

I don't believe tynes is correct here. The Holocene feature set has been frozen for a little while now with implementation well on the way. It's most likely these changes will need to be a part of Isthmus. We have channels in our discord to discuss hardfork changes. I'd recommend joining the discord and kicking off a thread in #hf-next channel about adding these changes and linking your spec pr.

[tynes]

We have general consensus on these changes being included in a future hardfork when they are ready. We should all make sure we agree on the design before saying anything is ready for inclusion

[refcell]

Hey @yuwen01, since there were a ton of merge conflicts due to changes I've introduced over the past month or so, I've went ahead and updated this based off your spec pr in ethereum-optimism/specs. Feel free to push changes if the spec changes or callout anything that doesn't look right to you :D

[refcell]

Warning

This is blocked from merging until the spec has been merged.

[refcell]

cc @emhane if you haven't seen this pr yet

[emhane]

lgtm

[emhane]

Suggested change

	let L1BlockInfoTx::Isthmus(decoded) =
	L1BlockInfoTx::decode_calldata(RAW_ISTHMUS_INFO_TX.as_ref()).unwrap()
	else {
	panic!("Wrong fork");
	};
	let L1BlockInfoTx::Isthmus(decoded) =
	L1BlockInfoTx::decode_calldata(RAW_ISTHMUS_INFO_TX.as_ref()).expect("Wrong fork");