Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ssz support for beacon request types #1099

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add ssz support for beacon request types #1099

wants to merge 1 commit into from

Conversation

programskillforverification
Copy link
Contributor

Motivation

close #1004

Solution

Add ssz trait implementation allowing encoding and decoding of beacon request types

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's no way to derive this?

we definitely want some test vectors for this,

@programskillforverification
Copy link
Contributor Author

I guess there's no way to derive this?

we definitely want some test vectors for this,

Yeah. What the tests looks like? I didn't find them on payload type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst will be requested when the pull request is marked ready for review gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] add ssz support for beacon request types
2 participants
@programskillforverification @mattsse