[WIP] Adding a VLFeat-compliant feature descriptor #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griwodz
added
type:feature
prio:major
in progress
cuda
griwodz
force-pushed
the
dev/vlfeat-like-descriptor
branch
from
4108d3d to
96397e9
Compare
griwodz
force-pushed
the
dev/vlfeat-like-descriptor
branch
from
be5729d to
da9cc32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All of PopSift's earlier descriptors were created by reading the Lowe paper again and again, attempting to understand how the descriptors should be implemented. We still believe that we followed the letter of the text, but apparently not the spirit.
Both Changchang Wu's implementation and VLFeat compute the descriptors differently. Furthermore, VLFeat's descriptors are rotated by a quarter circle compared to Changchang Wu's. This descriptor follows the VLFeat interpretation because it is the one that has been used by default in AliceVision.
Features list
Implementation remarks
At this point, the default PopSift behaviour is still to use our old interpretation. It is faster but obviously not exactly in the spirit off Lowe's idea. If this PR is accepted, should the default be vlfeat for compatibility reasons?