-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Continuous integration and CMake/CUDA #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The supported CCs are specified differently now, "native" and "all" simplify choices. libcudevrt is now a private dependencies of libpopsift. Applications using popsift with other CUDA functions may have to link it explicitly.
require at least Boost 1.71 for demo applications use Ubuntu 22.04 and CUDA SDK 11/12 use CMake to 3.24 remove cuBlas from linking, not used in PopSift
added dependencies on CUDAToolkit to config file change CC from native to all-major because build system has no GPU platform toolset for VS19 disable NVTX explicitly
let BUILD_SHARED_LIBS determine if popsift is built as shared or static using shared cudart library is given by CMAKE_CUDA_RUNTIME_LIBRARY
griwodz
force-pushed
the
dev/cmake-lang-cuda
branch
from
July 31, 2024 08:29
926d336
to
2175ee5
Compare
griwodz
changed the title
[WIP] CUDA as first order language
[WIP] Update to Continuous integration and CMake/CUDA
Jul 31, 2024
griwodz
changed the title
[WIP] Update to Continuous integration and CMake/CUDA
Update to Continuous integration and CMake/CUDA
Jul 31, 2024
This was referenced Aug 6, 2024
fabiencastan
reviewed
Aug 9, 2024
fabiencastan
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR makes two contributions that are partially interdependent:
CUDA as a first-order language has been available since CMake 3.18 and is in a good shape now. It is no longer necessary to hack linking and target behaviour, the creation of shared or non-shared libraries and target properties.
CI has been failing for a rather long while because the Linux, Visual Studio and CUDA versions were outdated. CI is now building the following combinations:
Features list
Implementation remarks