Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-fix] probeNum参数更新,loadRule生效 #583

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

578223592
Copy link

Describe what this PR does / why we need it

bug-fix

Does this pull request fix one issue?

Fixes

Describe how you did it

add more fields for compare

Describe how to verify it

add one more test case

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2024

CLA assistant check
All committers have signed the CLA.

@578223592 578223592 changed the title ### feature: [bug-fix] https://github.com/alibaba/sentinel-golang/pull/583 Oct 4, 2024
@578223592 578223592 changed the title [bug-fix] https://github.com/alibaba/sentinel-golang/pull/583 [bug-fix] probeNum参数更新,loadRule生效 Oct 4, 2024
@578223592 578223592 force-pushed the bug-fix/issue563/1004 branch from 52a2063 to 5784a81 Compare October 4, 2024 15:06
core/circuitbreaker/rule.go Outdated Show resolved Hide resolved
@578223592 578223592 requested a review from binbin0325 October 9, 2024 12:10
typo

Trigger CI

Signed-off-by: caicai <[email protected]>

Trigger CI

Signed-off-by: siwuxie <[email protected]>

delete redundant codes

comments format
@578223592 578223592 force-pushed the bug-fix/issue563/1004 branch from 08f6ff1 to 566193d Compare October 10, 2024 01:46
Copy link
Collaborator

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 64cf448 into alibaba:master Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants