fix: add traffic-type label to distinguish pass type, fix #501 #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/sentinel-golang?pullRequest=502 |
done |
jnan806
approved these changes
Jan 17, 2023
binbin0325
requested changes
Feb 3, 2023
core/stat/stat_slot.go
Outdated
| @@ -52,7 +52,7 @@ func (s *Slot) OnEntryPassed(ctx *base.EntryContext) { | |||
| s.recordPassFor(InboundNode(), ctx.Input.BatchCount) | |||
| } | |||
|
|
|||
| handledCounter.Add(float64(ctx.Input.BatchCount), ctx.Resource.Name(), ResultPass, "") | |||
| handledCounter.Add(float64(ctx.Input.BatchCount), ctx.Resource.Name(), ResultPass, "", ctx.Resource.FlowType().String()) | |||
There was a problem hiding this comment.
使用flowType 只能区分出inboud/outbound。 如果要区分出具体命中的rule类型，可以将命中的规则类型，暂存到ctx的data map中，然后在这里提取。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews