[WIP] Support RSC #6460
Closed
[WIP] Support RSC #6460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ClarkXia
reviewed
Aug 14, 2023
package.json
Outdated
| @@ -57,8 +57,8 @@ | |||
| "lint-staged": "^13.0.3", | |||
| "prettier": "^2.7.1", | |||
| "puppeteer": "^19.6.3", | |||
| "react": "^18.2.0", | |||
| "react-dom": "^18.2.0", | |||
| "react": "^18.3.0-canary-1cea38448-20230530", | |||
There was a problem hiding this comment.
如果启动 RSC 可以不用让开发者修改 react 版本，这个 canary 版本的维护放在 @ice/bundles 下，启用 RSC 后通过 alias 默认将 react 和 react-dom 指向框架内置的版本
| webpackConfig.plugins.push(new ReactServerWebpackPlugin({ | ||
| isServer: false, | ||
| clientReferences: [{ | ||
| directory: `${rootDir}/src`, |
There was a problem hiding this comment.
框架部分运行时代码在 .ice 目录和 @ice/runtime，这个插件相关逻辑可以考虑单独定制维护
wssgcg1213
reviewed
Aug 28, 2023
wssgcg1213
reviewed
Aug 28, 2023
|
see #6502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSC 第一版提交，客户端组件暂时还无法渲染