Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move oidcHandler from global to pluginconfig #1601

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rinfx
Copy link
Collaborator

@rinfx rinfx commented Dec 18, 2024

目前OIDC Handler放在全局变量中,会导致无法实现多域名支持,放在插件配置中后,可以结合域名级配置为每个域名创建一个oauth client,实现多域名的支持。

fixes #1600

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.50%. Comparing base (ef31e09) to head (92bccc4).
Report is 232 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
+ Coverage   35.91%   43.50%   +7.59%     
==========================================
  Files          69       76       +7     
  Lines       11576    12325     +749     
==========================================
+ Hits         4157     5362    +1205     
+ Misses       7104     6627     -477     
- Partials      315      336      +21     

see 69 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oidc插件域名级第二个不生效
2 participants