fix(core): nest array remove initial-value logic in destory #4052
+125
−29
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -514,6 +514,7 @@ test('array field remove memo leak', async () => { | |
| expect(initialValuesChange).toBeCalledTimes(0) | ||
| }) | ||
|
|
||
| // add sandbox https://codesandbox.io/p/devbox/lingering-violet-jwr565 | ||
| test('nest array remove', async () => { | ||
| const form = attach(createForm()) | ||
|
|
||
|
|
@@ -588,11 +589,84 @@ test('nest array remove', async () => { | |
| expect(form.fields['metrics.0.content.0.attr']).not.toBeUndefined() | ||
| await metrics.remove(1) | ||
| expect(form.fields['metrics.0.content.0.attr']).not.toBeUndefined() | ||
| // TODO!! 测试不通过 | ||
|
There was a problem hiding this comment. 这里是按照我当前的修复方案，form.initialValues 会被重置， 所以这个测试语句不通过 |
||
| expect( | ||
| form.initialValues.metrics?.[1]?.content?.[0]?.attr | ||
| ).not.toBeUndefined() | ||
| }) | ||
|
|
||
|
|
||
| test('nest array remove for #4024', () => { | ||
|
There was a problem hiding this comment. 情况二：针对 #4024 中反馈的问题， 我补充了一个测试用例 |
||
| const form = attach(createForm()) | ||
| const arr1 = attach( | ||
| form.createArrayField({ | ||
| name: 'aa', | ||
| initialValue: [{}], | ||
| }) | ||
| ) | ||
|
|
||
| attach( | ||
| form.createArrayField({ | ||
| name: 'bb', | ||
| basePath: 'aa.0', | ||
| initialValue: [{}], | ||
| }) | ||
| ) | ||
|
|
||
| attach( | ||
| form.createField({ | ||
| name: 'cc', | ||
| basePath: 'aa.0.bb.0', | ||
| initialValue: true, | ||
| }) | ||
| ) | ||
|
|
||
| expect(form.initialValues).toEqual({ | ||
| aa: [{ bb: [{ cc: true }] }], | ||
| }) | ||
|
|
||
| // 模拟两次 antd/ArrayBase.Addation 点击 | ||
| attach( | ||
| form.createField({ | ||
| name: 'cc', | ||
| basePath: 'aa.0.bb.1', | ||
| initialValue: true, | ||
| }) | ||
| ) | ||
| attach( | ||
| form.createField({ | ||
| name: 'cc', | ||
| basePath: 'aa.0.bb.2', | ||
| initialValue: true, | ||
| }) | ||
| ) | ||
| // 符合 formily DevTools 表现 | ||
| expect(form.initialValues).toEqual({ | ||
| aa: [{ bb: [{ cc: true }, { cc: true }, { cc: true }] }], | ||
| }) | ||
| // 模拟 antd/ArrayBase.Remove 点击 | ||
| arr1.remove(0) | ||
|
|
||
| // 模拟一次外部数组点击 antd/ArrayBase.Addation 点击 | ||
| attach( | ||
| form.createArrayField({ | ||
| name: 'bb', | ||
| basePath: 'aa.0', | ||
| initialValue: [{}], | ||
| }) | ||
| ) | ||
| attach( | ||
| form.createField({ | ||
| name: 'cc', | ||
| basePath: 'aa.0.bb.0', | ||
| initialValue: true, | ||
| }) | ||
| ) | ||
| expect(form.initialValues).toEqual({ | ||
| aa: [{ bb: [{ cc: true }] }], | ||
| }) | ||
| }) | ||
|
|
||
| test('indexes: nest path need exclude incomplete number', () => { | ||
| const form = attach(createForm()) | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
场景一：嵌套数组删除逻辑测试代码， 其中深层的数组的 initialValue 属性会改变 form.initialValues 值，针对这个测试， 我补充了一个 sandbox