Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dumi updated for node 18+ #4018

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

faner11
Copy link
Contributor

@faner11 faner11 commented Nov 3, 2023

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

What have you changed?

To be able to start the development service in a node 18+ environment

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e38de2a) 99.55% compared to head (e9b763d) 99.55%.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #4018   +/-   ##
=============================================
  Coverage         99.55%   99.55%           
=============================================
  Files               152      152           
  Lines              6717     6717           
  Branches           1880     1821   -59     
=============================================
  Hits               6687     6687           
- Misses               29       30    +1     
+ Partials              1        0    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@faner11 faner11 closed this Nov 3, 2023
@faner11 faner11 reopened this Nov 3, 2023
@janryWang
Copy link
Collaborator

确定能跑起来吗

@faner11
Copy link
Contributor Author

faner11 commented Nov 6, 2023

可以的,我18和20都试了,formily/antd 就是1.1.x 完全正常

@janryWang janryWang merged commit 48c9968 into alibaba:formily_next Nov 6, 2023
6 checks passed
@faner11 faner11 deleted the dumi-1.1.x branch November 6, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants