fix(configure): ignore data attributes #6380
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 393c969:
|
|
Thank you @Haroenv ❤️ |
JonasBa
reviewed
Oct 7, 2024
| @@ -5,7 +5,17 @@ import type { UseConfigureProps } from '../connectors/useConfigure'; | |||
| export type ConfigureProps = UseConfigureProps; | |||
|
|
|||
| export function Configure(props: ConfigureProps) { | |||
| useConfigure({ ...props }, { $$widgetType: 'ais.configure' }); | |||
| useConfigure( | |||
| Object.keys(props).reduce<ConfigureProps>((acc, key) => { | |||
There was a problem hiding this comment.
Worth leaving a comment here about Sentry being the cause of this issue for future readers?
victordelva
approved these changes
Dec 18, 2024
|
Thank you, @Haroenv Do you know of any workaround in the meantime? |
|
@victordelva you can apply this patch in your code base using for example patch-package. For the moment it seems that sentry is more responsible for patching their code to avoid adding attributes everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ignore data attributes in configure
Result
fixes getsentry/sentry-javascript#12720 (comment)
I'm not yet convinced this is the right approach for all cases (may cause a slowdown possibly, although we already were spreading the props). Alternatively this could be in
setQueryParameteror similar possibly, but would make that function more expensive.In the mean time, anyone using the sentry plugin can use this patch