feat: adds time range module #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
dphilipson
approved these changes
Dec 20, 2024
account-kit/smart-contracts/src/ma-v2/modules/time-range-module/module.ts
Outdated
Show resolved
Hide resolved
account-kit/smart-contracts/src/ma-v2/modules/time-range-module/module.ts
Show resolved
Hide resolved
account-kit/smart-contracts/src/ma-v2/modules/time-range-module/module.ts
Outdated
Show resolved
Hide resolved
linnall
requested review from
moldy530,
rthomare,
dancoombs and
mokok123
as code owners
howydev
force-pushed
the
howy/add-mav2-uo-call-encoding
branch
from
df3501a to
45d889c
Compare
Base automatically changed from
howy/add-mav2-uo-call-encoding
to
howy/add-install-validation
December 20, 2024 21:58
howydev
force-pushed
the
howy/add-install-validation
branch
from
d161f12 to
4e59a6f
Compare
Base automatically changed from
howy/add-install-validation
to
howy/scaffold-v0.8
December 20, 2024 22:02
fix: lint fix: review fixes feat: add view functions and user op calldata encodings feat: adds time module impl feat: adds time range module tests refactor: removes use of addresses, meta, and value field in args passed to encodeAbiParameters
linnall
force-pushed
the
linna/time-range-module-2
branch
from
ec759b8 to
6d7cee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces a new
TimeRangeModulefor managing time-based operations in the smart contract system. It adds functionality for encoding installation and uninstallation data based on time constraints and includes tests for these functionalities.Detailed summary
EntityIdOverrideErrorandDEFAULT_OWNER_ENTITY_IDimports ininstallValidation.ts.TimeRangeModulewith methods for encoding install and uninstall data inmodule.ts.TimeRangeModuleinclient.test.ts, verifying both valid and invalid time ranges.