feat: add native signer, implement signMessage and signTypedData #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
howydev
force-pushed
the
howy/add-mav2-uo-call-encoding
branch
from
55bb274 to
df3501a
Compare
howydev
force-pushed
the
howy/update-account-signers
branch
from
aee72be to
f9b5302
Compare
howydev
force-pushed
the
howy/update-account-signers
branch
from
bafb877 to
4b79e47
Compare
dphilipson
approved these changes
Dec 20, 2024
account-kit/smart-contracts/src/ma-v2/account/nativeSMASigner.ts
Outdated
Show resolved
Hide resolved
howydev
force-pushed
the
howy/add-mav2-uo-call-encoding
branch
from
df3501a to
45d889c
Compare
howydev
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
linnall
as code owners
Base automatically changed from
howy/add-mav2-uo-call-encoding
to
howy/add-install-validation
December 20, 2024 21:58
howydev
force-pushed
the
howy/add-install-validation
branch
from
d161f12 to
4e59a6f
Compare
Base automatically changed from
howy/add-install-validation
to
howy/scaffold-v0.8
December 20, 2024 22:02
howydev
force-pushed
the
howy/update-account-signers
branch
from
a498d5c to
ffed732
Compare
howydev
force-pushed
the
howy/update-account-signers
branch
from
ffed732 to
28cb13e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing signature packing utilities for user operations and 1271 signatures in the
account-kitsmart contracts, along with updating the account creation logic to utilize these new utilities.Detailed summary
PackSignatureParamstoPackUOSignatureParams.Pack1271SignatureParamsfor 1271 signature packing.pack1271Signaturefunction for 1271 signature packing.createSMAV2Accountto use_accountAddress.singleSignerMessageSignerto acceptchain,accountAddress, andentityId.