Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the missing default prop for verticalSwiping #2406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

islamethos
Copy link

Description:

This PR addresses an issue where the verticalSwiping prop was missing a default value, which impacted the filtering of component settings before passing them to the inner slider component. By adding the missing default prop, we ensure that verticalSwiping has a consistent value, preventing potential errors or inconsistent behavior.

Changes:

  • Added a default value for the verticalSwiping prop to ensure that it is not filtered out before being passed to the inner slider component.

Why this is necessary:

The absence of a default value for verticalSwiping caused the inner slider to behave incorrectly and led to unexpected behavior while swiping vertically in vertical mode.

@islamethos islamethos closed this Nov 18, 2024
@islamethos islamethos reopened this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants