Prep for renaming master branch to main #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezvz
approved these changes
Feb 21, 2024
kocolosk
reviewed
Feb 21, 2024
proposals/CHIP-1.md
Outdated
| @@ -144,7 +144,7 @@ The size of the cache should ideally be set in terms of maximum memory usage (e. | |||
|
|
|||
| ### Step 1: BatchIr Caching | |||
|
|
|||
| We start by caching the conversion from `batchBytes` to `FinalBatchIr` (the [toBatchIr function in FetcherBase](https://github.com/airbnb/chronon/blob/master/online/src/main/scala/ai/chronon/online/FetcherBase.scala#L102)) and `Map[String, AnyRef]`. | |||
| We start by caching the conversion from `batchBytes` to `FinalBatchIr` (the [toBatchIr function in FetcherBase](https://github.com/airbnb/chronon/blob/main/online/src/main/scala/ai/chronon/online/FetcherBase.scala#L102)) and `Map[String, AnyRef]`. | |||
|
|
|||
There was a problem hiding this comment.
Doesn't need to happen in this PR, but probably worth switching to some stable SHA for these examples, otherwise the next contribution to e.g. FetcherBase.scala is likely to break this pointer.
There was a problem hiding this comment.
Good catch! will update it to a stable sha
nikhilsimha
force-pushed
the
nikhil--master_rename
branch
from
7123add to
247eefe
Compare
pengyu-hou
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change code and documentation pointers - to point to a "main" branch instead of "master"
Why / Goal
the name "master" is culturally insensitive.
Test Plan
Checklist
Reviewers
@kocolosk @ezvz @hsaputra