Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] 66 #680

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[Release] 66 #680

merged 1 commit into from
Feb 7, 2024

Conversation

cristianfr
Copy link
Collaborator

@cristianfr cristianfr commented Feb 6, 2024

Summary

Why / Goal

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

@@ -5,7 +5,7 @@
"production": 1,
"customJson": "{\"lag\": 0, \"groupby_tags\": null, \"column_tags\": {}}",
"dependencies": [
"{\"name\": \"wait_for_{{ db }}.sample_team_sample_chaining_join_parent_join_ds\", \"spec\": \"{{ db }}.sample_team_sample_chaining_join_parent_join/ds={{ ds }}\", \"start\": \"2023-04-15\", \"end\": null}"
"{\"name\": \"wait_for_chronon_db.sample_team_sample_chaining_join_parent_join_ds\", \"spec\": \"chronon_db.sample_team_sample_chaining_join_parent_join/ds={{ ds }}\", \"start\": \"2023-04-15\", \"end\": null}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Finally we fixed this.

@cristianfr cristianfr merged commit ac5095b into master Feb 7, 2024
6 of 7 checks passed
@cristianfr cristianfr deleted the crf-release-66 branch February 7, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants