-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to use macOS 14 #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it builds, lgtm
@@ -39,7 +24,7 @@ jobs: | |||
swift-action: 'test' | |||
|
|||
validate-podspec: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to get this working we'll likely need to bump up CocoaPods in the Gemfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right -- the job passes now after updating to the latest version of cocoapods
run: sudo xcode-select -switch /Applications/Xcode_11.7.app | ||
- name: Generate linux tests | ||
# Makes sure the linux tests were generated properly (can only be run on macOS) | ||
run: swift test --generate-linuxmain && git update-index --refresh && git diff-index --quiet HEAD -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may no longer exist:
error: Unknown option '--generate-linuxmain'
Not sure why we would need this since we also have the build-linux
job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that much bout what this was doing. here's what my linux tests tend to look like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the logs in the build-linux
job, it does run the tests. So, that part seems fine as-is.
CI currently specifies macOS 11, which is no longer supported on GitHub actions.
This PR updates CI to use macOS 14 / Xcode 15.4.