Bootloader force user input #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12431357610Details
💛 - Coveralls |
imobachgs
reviewed
Dec 18, 2024
jreidinger
force-pushed
the
bootloader_force_user_input
branch
2 times, most recently
from
9a8d488 to
5492568
Compare
imobachgs
approved these changes
Dec 19, 2024
rust/agama-lib/src/bootloader.rs
Outdated
| //! Implements support for handling the storage settings | ||
|
|
||
| pub mod client; | ||
| // pub mod http_client; |
imobachgs
approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
Merged
dgdavid
added a commit
that referenced
this pull request
Dec 23, 2024
## Problem There is collision between #1848 and #1840 where bootloader adds another interface with Get/SetConfig on Storage service. This result that generic access no longer works and needs access via specific interface. reported on slack https://suse.slack.com/archives/C02TLF25571/p1734924853266999 ## Solution Change code to avoid ambitious code. ## Testing - *Tested manually*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to support the QA use-case, we need to make it possible to configure the boot loader to stop at the menu without a timeout.
trello: https://trello.com/c/dKYmc0K7/4018-5-agama-ped-10810-new-section-to-configure-bootloader
jira:
Solution
Add to profile section
Bootloaderwith keystopOnBootMenuand boolean value. This allows QA to usejq -n ".bootloader.stopOnBootMenu = true" | agama config loadafter selecting product and before start of installation to force stop without any timeout.Testing