make rubocop happy and fix tests

service/lib/agama/registration.rb

@@ -30,8 +30,7 @@
 module Agama
   # Handles everything related to registration of system to SCC, RMT or similar.
   class Registration
-
-    # Note: identical and keep in sync with Software::Manager::TARGET_DIR
+    # NOTE: identical and keep in sync with Software::Manager::TARGET_DIR
     TARGET_DIR = "/run/agama/zypp"
     private_constant :TARGET_DIR
 
@@ -95,7 +94,8 @@ def register(code, email: "")
       # if service require specific credentials file, store it
       @credentials_file = credentials_from_url(@service.url)
       if @credentials_file
-        SUSE::Connect::YaST.create_credentials_file(login, password, File.join(TARGET_DIR, @credentials_file))
+        SUSE::Connect::YaST.create_credentials_file(login, password,
+          File.join(TARGET_DIR, @credentials_file))
       end
       Y2Packager::NewRepositorySetup.instance.add_service(@service.name)
       @software.add_service(@service)

service/test/agama/registration_test.rb

@@ -90,7 +90,7 @@
 
         it "creates credentials file" do
           expect(SUSE::Connect::YaST).to receive(:create_credentials_file)
-            .with("test-user", "12345")
+            .with("test-user", "12345", "/run/agama/zypp/etc/zypp/credentials.d/SCCcredentials")
 
           subject.register("11112222", email: "[email protected]")
         end
@@ -117,13 +117,14 @@
 
           before do
             allow(subject).to receive(:credentials_from_url)
-              .with("https://credentials/file").and_return("credentials")
+              .with("https://credentials/file")
+              .and_return("/etc/zypp/credentials.d/product")
           end
 
           it "creates the credentials file" do
             expect(SUSE::Connect::YaST).to receive(:create_credentials_file)
             expect(SUSE::Connect::YaST).to receive(:create_credentials_file)
-              .with("test-user", "12345", "credentials")
+              .with("test-user", "12345", "/run/agama/zypp/etc/zypp/credentials.d/product")
 
             subject.register("11112222", email: "[email protected]")
           end