Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional refactor #81

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Functional refactor #81

wants to merge 19 commits into from

Conversation

LukasMahieu
Copy link
Collaborator

Functional Refactor of crested.tl.Crested(...) class

In this large refactor I'm moving everything from the Crested class that does not use both a model and the AnnDatamodule out to a new _tools.py module where everything will be functional.
All the old functions remain in the Crested class for backward compatibility (for now) but will now raise a deprecation warning.

I'm giving up a bit of clarity for ease of use by combining functions that do the same on different inputs into one single function.

Equivalent new functions

  • tl.Crested.get_embeddings(...) ---> tl.extract_layer_embeddings(...)
  • tl.Crested.predict(...) ---> tl.predict(...)
  • tl.Crested.predict_regions(...) ---> tl.predict(...)
  • tl.Crested.predict_sequence(...) ---> tl.predict(...)
  • tl.Crested.score_gene_locus(...) ---> tl.score_gene_locus(...)
  • tl.Crested.calculate_contribution_scores(...) ---> tl.contribution_scores(...)
  • tl.Crested.calculate_contribution_scores_regions(...) ---> tl.contribution_scores(...)
  • tl.Crested.calculate_contribution_scores_sequence(...) ---> tl.contribution_scores(...)
  • tl.Crested.calculate_contribution_scores_enhancer_design(...) ---> tl.contribution_scores(...)
  • tl.Crested.tfmodisco_calculate_and_save_contribution_scores_sequences ---> tl.contribution_scores_specific(...)
  • tl.Crested.tfmodisco_calculate_and_save_contribution_scores ---> tl.contribution_scores(...)
  • tl.Crested.enhancer_design_motif_implementation --->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant