Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1241 Add concurrent scans limiter #113

Merged
merged 21 commits into from
Aug 12, 2024
Merged

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review August 11, 2024 06:51
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (4822898) to head (17428e5).

Files Patch % Lines
io/aerospike/record_reader.go 33.33% 4 Missing and 2 partials ⚠️
client.go 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   80.57%   80.57%   -0.01%     
==========================================
  Files          62       62              
  Lines        3218     3238      +20     
==========================================
+ Hits         2593     2609      +16     
- Misses        432      436       +4     
  Partials      193      193              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reugn reugn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add coverage for the client options.

client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
examples/aws/s3/main.go Outdated Show resolved Hide resolved
examples/readme/main.go Outdated Show resolved Hide resolved
@korotkov-aerospike korotkov-aerospike merged commit 923a5dc into main Aug 12, 2024
9 checks passed
@korotkov-aerospike korotkov-aerospike deleted the scan_limiter branch August 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants