Skip to content

Ensure that doorkeeper_token is valid when authenticating requests in API v2 calls

High severity GitHub Reviewed Published Oct 20, 2020 in spree/spree • Updated May 4, 2023

Package

bundler spree (RubyGems)

Affected versions

< 3.7.11
>= 4.0.0, < 4.0.4
>= 4.1.0, < 4.1.11

Patched versions

3.7.11
4.0.4
4.1.11

Description

Impact

The perpetrator who previously obtained an old expired user token could use it to access Storefront API v2 endpoints.

Patches

Please upgrade to 3.7.11, 4.0.4, or 4.1.11 depending on your used Spree version.

Workarounds

In your project directory create a decorator file app/controllers/spree/api/v2/base_controller_decotatror.rb with contents:

module Spree
  module Api
    module V2
      module BaseControllerDecorator
        private

        def spree_current_user
          return nil unless doorkeeper_token
          return @spree_current_user if @spree_current_user

          doorkeeper_authorize!

          @spree_current_user ||= ::Spree.user_class.find_by(id: doorkeeper_token.resource_owner_id)
        end
     end
  end
end

Spree::Api::V2::BaseController.prepend(Spree::Api::V2::BaseControllerDecorator)

For more information

If you have any questions or comments about this advisory:

References

@damianlegawiec damianlegawiec published to spree/spree Oct 20, 2020
Reviewed Oct 20, 2020
Published to the GitHub Advisory Database Oct 20, 2020
Published by the National Vulnerability Database Oct 20, 2020
Last updated May 4, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
High
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
High
Availability
None

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:N

EPSS score

0.135%
(49th percentile)

Weaknesses

CVE ID

CVE-2020-15269

GHSA ID

GHSA-f8cm-364f-q9qh

Source code

Credits

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.