Removing also dash "-" and underscore "_" from repository name #3727
Conversation
this is partially bound to adoptium#3724, where dash and underscore are one of major delimiters in directory names jdk11u-my_feature May, or may have not sense without the 3724
judovana
force-pushed
the
betterMajorFromName
branch
from
ceea82b to
f757cb3
Compare
I do not have strong prefference on this commit, but names like jdk17u.zip may be pretty common
|
Please let me know, if this have sense standalone, or only as part of #3724 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
|
Let's make it part of 3724, easier to track the discussion there. |
|
Sure! ty! |
|
Just for record. This PR was very wrong. The final argumenr, which is santised on this line, is strictly I will do a PR, which will be asserting that the mandatory argument of jdkXY is correct. |
|
Surpassed by #3728 |
this is partially bound to #3724, where dash and underscore are one of major delimiters in directory names jdk11u-my_feature
May, or may have not sense without the 3724