Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows sign.sh retry and check curl rc #3490

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Oct 2, 2023

Add retry logic to sign.sh for Windows, due to frequent failures recently with 502 returned from eclipse sign service.
Also since the script uses "set -eu", if curl returns say rc 502, which is happening frequently the script exits... so added if return code check.

@andrew-m-leonard andrew-m-leonard self-assigned this Oct 2, 2023
@github-actions github-actions bot added the installer Issues that relate to our installer jobs or installer repo label Oct 2, 2023
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Oct 2, 2023

Successful test run with a failure: https://ci.adoptium.net/job/build-scripts/job/release/job/sign_build/26632/console

Signing ./bin/jrunscript.exe
Signing ./bin/jrunscript.exe using Eclipse Foundation codesign service
curl: (22) The requested URL returned error: 502 
curl command failed, sign of ./bin/jrunscript.exe failed
Code Not Signed For File ./bin/jrunscript.exe
1 Of 20
curl: (22) The requested URL returned error: 502 
curl command failed, ./bin/jrunscript.exe Failed Signing On Attempt 1
2 Of 20
./bin/jrunscript.exe Signed OK On Attempt 2

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrew-m-leonard andrew-m-leonard merged commit 751e5c8 into adoptium:master Oct 2, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer Issues that relate to our installer jobs or installer repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants