Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: bump JDK11 x86 build to use VS2019 #3144

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdams
Copy link
Member

@gdams gdams commented Nov 2, 2022

We recently bumped x64 build to VS2019, this PR adds x86 so that we're consistent again

Also removed some old JDK9 and JDK10 if statements.

Test build: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-windows-x86-32-temurin/141/

@github-actions github-actions bot added the windows Issues that affect or relate to the WINDOWS OS label Nov 2, 2022
@github-actions github-actions bot added the testing Issues that enhance or fix our test suites label Nov 7, 2022
@gdams gdams marked this pull request as ready for review November 7, 2022 19:04
@zdtsw zdtsw requested review from andrew-m-leonard and sxa November 8, 2022 07:57
@gdams gdams marked this pull request as draft November 8, 2022 08:47
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams
Copy link
Member Author

gdams commented Nov 8, 2022

Marked as draft as build failed so needs investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants