Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnixPb: Set xcode switch path to full path on build machines #2504

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Mar 11, 2022

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref adoptium/temurin-build#2876 and https://adoptium.slack.com/archives/C09NW3L2J/p1646743526526249

The xcode switch path can be set to "/Applications/Xcode.app" for jdk8, 11 and 17+. Hence this can be set as the default path in the playbooks, without having to execute the commands in the build scripts

@Haroon-Khel Haroon-Khel requested review from sxa and gdams March 11, 2022 12:44
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel merged commit c084aa3 into adoptium:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants