Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance platform requirements mechanism #178

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Enhance platform requirements mechanism #178

merged 1 commit into from
Apr 27, 2021

Conversation

renfeiw
Copy link
Contributor

@renfeiw renfeiw commented Apr 12, 2021

  • the new feature utilize regex to specify platform

fixes #166

Signed-off-by: renfeiw [email protected]

@renfeiw
Copy link
Contributor Author

renfeiw commented Apr 12, 2021

run aqa --sdk_resource nightly --build_list openjdk --target sanity.openjdk --jdk_version 11 --jdk_impl hotspot --platform x86-64_linux

@github-actions
Copy link

@renfeiw Build(s) started with the following parameters:

  • sdk_resource: ['nightly']
  • customized_sdk_url: ['None']
  • archive_extension: ['.tar']
  • build_list: ['openjdk']
  • target: ['_sanity.openjdk']
  • platform: ['ubuntu-latest']
  • jdk_version: ['11']
  • jdk_impl: ['hotspot']
  • openjdk_testrepo: ['AdoptOpenJDK/openjdk-tests:master']

Workflow Run ID: 742298901

@github-actions
Copy link

@renfeiw Build(s) failed.
Workflow Run ID: 742298901

@renfeiw
Copy link
Contributor Author

renfeiw commented Apr 12, 2021

run aqa --sdk_resource nightly --build_list openjdk --target sanity.openjdk --jdk_version 11 --jdk_impl hotspot --platform x86-64_linux

@github-actions
Copy link

@renfeiw Build(s) started with the following parameters:

  • sdk_resource: ['nightly']
  • customized_sdk_url: ['None']
  • archive_extension: ['.tar']
  • build_list: ['openjdk']
  • target: ['_sanity.openjdk']
  • platform: ['ubuntu-latest']
  • jdk_version: ['11']
  • jdk_impl: ['hotspot']
  • openjdk_testrepo: ['AdoptOpenJDK/openjdk-tests:master']

Workflow Run ID: 742330806

@github-actions
Copy link

@renfeiw Build(s) failed.
Workflow Run ID: 742330806

@renfeiw
Copy link
Contributor Author

renfeiw commented Apr 13, 2021

The failed test in workflow run is not related.

@renfeiw
Copy link
Contributor Author

renfeiw commented Apr 15, 2021

internal tested: Grinder_TKG/1215/

@renfeiw renfeiw requested review from llxia and smlambert April 15, 2021 20:23
@renfeiw renfeiw marked this pull request as ready for review April 15, 2021 20:23
@karianna karianna added the enhancement New feature or request label Apr 16, 2021
@karianna karianna added this to the April 2021 milestone Apr 16, 2021
@renfeiw
Enhance platform requirements mechanism
c60dc1c 
- the new feature utilize regex to specify platform

fixes adoptium#166

Signed-off-by: renfeiw <[email protected]>
@renfeiw
Copy link
Contributor Author

renfeiw commented Apr 26, 2021

run aqa --sdk_resource nightly --build_list openjdk --target sanity.openjdk --jdk_version 11 --jdk_impl hotspot --platform x86-64_linux

@github-actions
Copy link

@renfeiw Build(s) started with the following parameters:

  • sdk_resource: ['nightly']
  • customized_sdk_url: ['None']
  • archive_extension: ['.tar']
  • build_list: ['openjdk']
  • target: ['_sanity.openjdk']
  • platform: ['ubuntu-latest']
  • jdk_version: ['11']
  • jdk_impl: ['hotspot']
  • openjdk_testrepo: ['AdoptOpenJDK/openjdk-tests:master']

Workflow Run ID: 786857238

@renfeiw
Copy link
Contributor Author

renfeiw commented Apr 26, 2021

internal build: Grinder_TKG/1218

@github-actions
Copy link

@renfeiw Build(s) successful.
Workflow Run ID: 786857238

llxia
llxia approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smlambert
smlambert approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit 81e9cbe into adoptium:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
April 2021
Development

Successfully merging this pull request may close these issues.

Enhance platform requirements mechanism for TKG
4 participants
@renfeiw @smlambert @llxia @karianna