Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance platform requirements mechanism for TKG #166

Open
renfeiw opened this issue Mar 23, 2021 · 1 comment · Fixed by #178
Open

Enhance platform requirements mechanism for TKG #166

renfeiw opened this issue Mar 23, 2021 · 1 comment · Fixed by #178
Labels
enhancement New feature or request
Milestone

Comments

@renfeiw
Copy link
Contributor

renfeiw commented Mar 23, 2021

We are using <platformRequirements> to specify the spec to test against. It provides some degree of freedom to define os, arch, bit information, but it's limited (only support and relationship) and sometimes difficult to read and write.

A better way is to utilize regular expression to define the platform. Another step to improve the mechanism to use platform instead of spec to define the information. Since they are more clear and intuitive because it matches the build names.

@renfeiw renfeiw added the enhancement New feature or request label Mar 23, 2021
renfeiw added a commit to renfeiw/TKG that referenced this issue Mar 25, 2021
- the new feature utilize regex to specify platform

fixes adoptium#166

Signed-off-by: renfeiw <[email protected]>
renfeiw added a commit to renfeiw/TKG that referenced this issue Apr 12, 2021
- the new feature utilize regex to specify platform

fixes adoptium#166

Signed-off-by: renfeiw <[email protected]>
renfeiw added a commit to renfeiw/TKG that referenced this issue Apr 26, 2021
- the new feature utilize regex to specify platform

fixes adoptium#166

Signed-off-by: renfeiw <[email protected]>
@karianna karianna added this to the April 2021 milestone Apr 28, 2021
@renfeiw renfeiw reopened this Jul 3, 2021
@renfeiw
Copy link
Contributor Author

renfeiw commented Jul 3, 2021

This feature is implemented, but we will make transformation to it util the platform naming gets unified: adoptium/aqa-tests#2706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants