Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE_HEADER.md with Apache 2 License URL #13

Closed
wants to merge 2 commits into from

Conversation

frunkad
Copy link
Contributor

@frunkad frunkad commented Oct 3, 2019

Updated the URL at Line 74

Description

Changed

https://inside.corp.adobe.com/intellectual-property/copyrights.html#jcr-content_par_tab_Adobe-Copyright-Notices
to
http://www.apache.org/licenses/LICENSE-2.0

Related Issue

#10

Motivation and Context

The Copyright URL was of the Adobe Corporate instead of Apache Copyright URL

How Has This Been Tested?

Markdown edit, doesn't require explicit testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@filmaj
Copy link
Contributor

filmaj commented Oct 3, 2019

I think we could actually just remove this section as it is not that helpful.

@frunkad
Copy link
Contributor Author

frunkad commented Oct 4, 2019

Shall I go ahead with removing the complete other license section or just the link line?

Also, though it might not be useful, having a direct link to the License file shares more detail and (personally) I believe it might be good to keep.

@filmaj
Copy link
Contributor

filmaj commented Oct 6, 2019

Yes if you can remove the section that would be great, and I would accept the PR.

@filmaj filmaj mentioned this pull request Oct 6, 2019
3 tasks
@frunkad
Copy link
Contributor Author

frunkad commented Oct 6, 2019

Made the changes. Small confusion: I created a new commit to my fork's patch-1 branch. Does that also update this PR or do I need to do something extra?

@filmaj
Copy link
Contributor

filmaj commented Oct 7, 2019

Lol, sorry, I meant just remove the "for more info check out this corporate URL" section 🙈

Maybe best to start fresh? I'll close this PR but if you're still up for it feel free to send another PR.

@filmaj filmaj closed this Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants