Broken internal links priority

[nitinja]

Related Issues

https://jira.corp.adobe.com/browse/SITES-27242

Linked PR: adobe/spacecat-shared#491

Test cases coming soon.

✅ Data accuracy: I have validated the results. The new results match old/existing results. Hence this implementation is accurate.

This PR changes RUM event from 404 to 404 and navigate. It also removes associated logic to filter links from same sources since it's now done from the RUM client itself.

It also adds logic to calculate priorities based on page views for each link in following way (as discussed in Figma prototype).
Priority: High: top 25%, Medium: next 25%, Low: bottom 50%

**Note: I believe this logic can be improved for much more correctness. I will be discussing with team about this logic and will come up with more optimized logic. **

Sample data input

[
  {
    "id": "56ou",
    "host": "rum.hlx.page",
    "time": "2024-11-23T23:00:01.858Z",
    "timeSlot": "2024-11-23T23:00:00.000Z",
    "url": "https://www.petplace.com/a01",
    "userAgent": "mobile:android:blink",
    "weight": 200,
    "events": [
      {
        "checkpoint": "navigate",
        "target": "visible",
        "source": "https://www.petplace.com/a01nf",
        "timeDelta": 1858
      },
      {
        "checkpoint": "navigate",
        "target": "visible",
        "source": "https://www.petplace.com/a01nf",
        "timeDelta": 1654
      },
      {
        "checkpoint": "404",
        "target": "",
        "source": "https://www.petplace.com/a01nf",
        "timeDelta": 218
      }
    ]
  },
  {
    "id": "2no",
    "host": "rum.hlx.page",
    "time": "2024-11-22T18:00:00.544Z",
    "timeSlot": "2024-11-22T18:00:00.000Z",
    "url": "https://www.petplace.com/a01",
    "userAgent": "desktop:windows:blink",
    "weight": 1800,
    "events": [
      {
        "checkpoint": "navigate",
        "target": "visible",
        "source": "https://www.petplace.com/a02nf",
        "timeDelta": 542
      },
      {
        "checkpoint": "404",
        "target": "xxxx",
        "source": "https://www.petplace.com/a02nf",
        "timeDelta": 45
      }
    ]
  },
  {
    "id": "4FGLNSev",
    "host": "rum.hlx.page",
    "time": "2024-11-23T23:00:33.919Z",
    "timeSlot": "2024-11-23T23:00:00.000Z",
    "url": "https://www.petplace.com/a01",
    "userAgent": "desktop:mac:blink",
    "weight": 100,
    "events": [
      {
        "checkpoint": "navigate",
        "target": "hidden",
        "source": "https://www.petplace.com/a03",
        "timeDelta": -3599620
      }
    ]
  },
  {
    "id": "Hdq",
    "host": "rum.hlx.page",
    "time": "2024-11-24T00:00:00.111Z",
    "timeSlot": "2024-11-24T00:00:00.000Z",
    "url": "https://www.petplace.com/a01",
    "userAgent": "mobile:android:blink",
    "weight": 100,
    "events": []
  },
  {
    "id": "9DTknv",
    "host": "rum.hlx.page",
    "time": "2024-11-24T00:00:14.264Z",
    "timeSlot": "2024-11-24T00:00:00.000Z",
    "url": "https://www.petplace.com/a01",
    "userAgent": "mobile:android:blink",
    "weight": 100,
    "events": []
  },
  {
    "id": "9LOQXfu",
    "host": "rum.hlx.page",
    "time": "2024-11-22T23:00:00.581Z",
    "timeSlot": "2024-11-22T23:00:00.000Z",
    "url": "https://www.petplace.com/a01",
    "userAgent": "mobile:ios:webkit",
    "weight": 100,
    "events": [
      {
        "checkpoint": "404",
        "target": "https://www.petplace.com/a04nf",
        "source": "",
        "timeDelta": 198
      }
    ]
  },
  {
    "id": "047B",
    "host": "rum.hlx.page",
    "time": "2024-11-20T20:00:01.683Z",
    "timeSlot": "2024-11-20T20:00:00.000Z",
    "url": "https://www.petplace.com/ax02",
    "userAgent": "desktop:windows",
    "weight": 700,
    "events": [
      {
        "checkpoint": "404",
        "target": "ddd",
        "source": "https://www.petplace.com/ax02nf",
        "timeDelta": 259
      },
      {
        "checkpoint": "navigate",
        "target": "hidden",
        "source": "https://www.petplace.com/ax02nf",
        "timeDelta": 1680
      }
    ]
  },
  {
    "id": "048C",
    "host": "rum.hlx.page",
    "time": "2024-11-20T20:00:01.683Z",
    "timeSlot": "2024-11-20T20:00:00.000Z",
    "url": "https://www.petplace.com/ax02",
    "userAgent": "desktop:windows",
    "weight": 500,
    "events": [
      {
        "checkpoint": "404",
        "target": "ddd",
        "source": "https://www.petplace.com/ax02nf",
        "timeDelta": 259
      },
      {
        "checkpoint": "navigate",
        "target": "hidden",
        "source": "https://www.petplace.com/ax02nf",
        "timeDelta": 1680
      }
    ]
  }
]

Sample output

[
      {
        "traffic_domain": 1800,
        "url_to": "https://www.petplace.com/a01",
        "url_from": "https://www.petplace.com/a02nf",
        "priority": "high"
      },
      {
        "traffic_domain": 1200,
        "url_to": "https://www.petplace.com/ax02",
        "url_from": "https://www.petplace.com/ax02nf",
        "priority": "medium"
      },
      {
        "traffic_domain": 200,
        "url_to": "https://www.petplace.com/a01",
        "url_from": "https://www.petplace.com/a01nf",
        "priority": "low"
      }
    ]

[github-actions]

This PR will trigger no release when merged.

[ekremney]

in the implementation, priority is set to either high, medium, or low; but why it does end up as an integer here?

[nitinja]

This is a mistake - leftover code from initial implementation of priorities. I will take care of this while implementing test cases which is not done yet. thx

[solaris007]

🎉 This PR is included in version 1.45.3 🎉

The release is available on:

• v1.45.3
• GitHub release

Your semantic-release bot 📦🚀