Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add presigned screenshot url for opportunity #511

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Conversation

rpapani
Copy link
Contributor

@rpapani rpapani commented Dec 5, 2024

  • Creates a pre-signed url valid for 7 days for screenshot-desktop.png and screenshot-desktop-thumbnail.png
  • Temporary solution before https://jira.corp.adobe.com/browse/SITES-26132 is fixed.
  • Unable to add tests due to AWSXray, as this is the default export and unable to stub it, so skipping the tests for getPresignedUrl

Copy link

github-actions bot commented Dec 5, 2024

This PR will trigger a minor release when merged.

@rpapani rpapani marked this pull request as ready for review December 6, 2024 18:35
@rpapani rpapani requested review from shrotia and ramboz December 6, 2024 18:50
Key: screenshotPath,
});
const signedUrl = await getSignedUrl(s3Client, command, {
expiresIn: 7 * 24 * 60 * 60, // 7 days in seconds
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: this could be extracted as a constant and evaluated once at the top of the file

@rpapani rpapani merged commit c693f21 into main Dec 13, 2024
4 checks passed
@rpapani rpapani deleted the oppty-screenshot branch December 13, 2024 20:35
solaris007 pushed a commit that referenced this pull request Dec 13, 2024
# [1.43.0](v1.42.5...v1.43.0) (2024-12-13)

### Features

* add presigned screenshot url for opportunity ([#511](#511)) ([c693f21](c693f21))
@solaris007
Copy link
Member

🎉 This PR is included in version 1.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants