Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rum-oversight): unknown filter should return empty set #9

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

karlpauls
Copy link
Collaborator

This applies adobe/helix-website#667 to the distiller.

@karlpauls karlpauls requested a review from trieloff October 14, 2024 10:48
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (55d4b3b) to head (e36ea0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   90.44%   90.57%   +0.12%     
==========================================
  Files          13       13              
  Lines        3421     3468      +47     
==========================================
+ Hits         3094     3141      +47     
  Misses        327      327              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karlpauls karlpauls requested a review from kptdobe October 14, 2024 10:48
@karlpauls
Copy link
Collaborator Author

@kptdobe, I'm trying to apply your change to oversight to the distiller - does this look correct (let me know if you rather want to create a PR yourself)?

Notice that I added the following:

--- a/tools/oversight/test/cruncher.test.js
+++ b/tools/oversight/test/cruncher.test.js
@@ -776,6 +776,7 @@ describe('DataChunks', () => {
     d.load(chunks1);
 
     // define facet functions
+    d.addFacet('host', (bundle) => bundle.host);
     d.addFacet(
       // as a convention, we use ! to indicate negation. When used in URL parameters, this
       // looks like a nice filter:  ?userAgent!=desktop

To make the tests pass (/cc @trieloff )

@kptdobe
Copy link
Contributor

kptdobe commented Oct 14, 2024

Yes, the host was missing in the test. I added it in my original PR: https://github.com/adobe/helix-website/pull/663/files#diff-52e8567f03066b4a3b5679116feddeffb369c606a16601299b7f3cbecbd5ae9aR700
I may have forgotten the line during "the backport"

@karlpauls karlpauls merged commit 9554e62 into main Oct 14, 2024
7 checks passed
adobe-bot pushed a commit that referenced this pull request Oct 14, 2024
## [1.4.1](v1.4.0...v1.4.1) (2024-10-14)

### Bug Fixes

* **rum-oversight:** unknown filter should return empty set ([#9](#9)) ([9554e62](9554e62))
@adobe-bot
Copy link

🎉 This PR is included in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants