Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Math.max crashes if too many deltas #698

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: Math.max crashes if too many deltas #698

merged 1 commit into from
Dec 13, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Dec 13, 2024

Math.max(...array) cannot be used if array has a lot of elements

Last week, adobe.com had a weird session with 163665 click events! This makes the oversight/explorer crash.

Before: https://www.aem.live/tools/oversight/explorer.html?domain=www.adobe.com&filter=&view=week&=performance
After: https://max-crash--helix-website--adobe.aem.live/tools/oversight/explorer.html?domain=www.adobe.com&filter=&view=week&=performance

@kptdobe kptdobe requested a review from trieloff December 13, 2024 14:27
Copy link

aem-code-sync bot commented Dec 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@kptdobe kptdobe merged commit fc11ecd into main Dec 13, 2024
3 of 4 checks passed
@kptdobe kptdobe deleted the max-crash branch December 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants