Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to rum-distiller for oversight #669

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

karlpauls
Copy link
Collaborator

With the new rum-distiller (https://github.com/adobe/rum-distiller) project we are trying to factor out the cruncher and the definitions of the series and facets into a common project.

Test: https://distiller-oversight--helix-website--adobe.aem.live/tools/oversight/explorer.html?domain=blog.adobe.com&domainkey=incognito

Copy link

aem-code-sync bot commented Oct 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@karlpauls karlpauls requested a review from trieloff October 11, 2024 11:07
Copy link

aem-code-sync bot commented Oct 11, 2024

@aem-code-sync aem-code-sync bot temporarily deployed to distiller-oversight October 11, 2024 11:42 Inactive
Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost great.

package.json Outdated Show resolved Hide resolved
@karlpauls karlpauls marked this pull request as ready for review October 14, 2024 15:40
@karlpauls karlpauls merged commit bdb5d5e into main Oct 15, 2024
3 of 4 checks passed
@karlpauls karlpauls deleted the distiller-oversight branch October 15, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants