Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter while typing and reduce number #659

Merged
merged 3 commits into from
Nov 19, 2024
Merged

feat: filter while typing and reduce number #659

merged 3 commits into from
Nov 19, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Sep 25, 2024

Make the list smaller and filter while typing with a startsWith

https://domains-tweaks--helix-website--adobe.aem.live/tools/rum/explorer.html?domain=

@kptdobe kptdobe requested a review from maxakuru September 25, 2024 09:31
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Sep 25, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Sep 25, 2024 •
edited
Loading

Page Scores Audits Google
📱 /tools/rum/explorer.html?domain= PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /tools/rum/explorer.html?domain= PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

maxakuru
maxakuru approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@maxakuru maxakuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the datalist should filter on input by default.. I'm guessing this is because 100 is an overwhelming amount? that's fair

@kptdobe
Copy link
Contributor Author

kptdobe commented Sep 26, 2024

the datalist should filter on input by default

It does but not like a autocomplete, it searches in the whole strings.
100 is not an issue for the autocomplete but for the UX: it's just too big.

@kptdobe kptdobe merged commit fbf3147 into main Nov 19, 2024
1 of 3 checks passed
@kptdobe kptdobe deleted the domains-tweaks branch November 19, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxakuru maxakuru maxakuru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kptdobe @maxakuru