feat(oversight): show that iOS CWVs are fake #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 2024, CWV readings with iOS user agents are coming from non-iOS browsers that falsify their user agent string. This can include Chrome when using devtools and simulating a mobile viewport. Apple does not allow custom rendering engines in most of the world, and in the EU, where it does allow custom rendering engines, no browser vendor ships a browser with a non-WebKit engine, so that all actual iOS browsers are just WebKit in disguise. Webkit does not implement key APIs required for measurement of Core Web Vitals, effectively rendering all CWVs readings that claim to apply to iOS suspect. This PR addresses this by reducing the visual contrast of the CWV pills for the user agent iOS only.
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 2024, CWV readings with iOS user agents are coming from non-iOS browsers
that falsify their user agent string. This can include Chrome when using devtools
and simulating a mobile viewport. Apple does not allow custom rendering engines
in most of the world, and in the EU, where it does allow custom rendering engines,
no browser vendor ships a browser with a non-WebKit engine, so that all actual
iOS browsers are just WebKit in disguise. Webkit does not implement key APIs required
for measurement of Core Web Vitals, effectively rendering all CWVs readings that
claim to apply to iOS suspect.
This PR addresses this by reducing the visual contrast of the CWV pills for the
user agent iOS only.