Support Negative URL Facet #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a facet in the URL parameters like `&url!=https://example.com/irrelevant`
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
This avoids problems when the same function is reused for multiple facets
…acet exists) by holding shift while selecting facet value
…rroring regular facet e.g. when excluding the `/tutorial` URL, you still want to show how many possible `/tutorial` page views have been excluded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of now, this PR does not come with a UI, and it is only limited to the URL facet. You can try it
by appending
&url!=https://examplehost.com/examplepath– this will then exclude that particular URLfrom all results shown in the UI. I haven't tried what happens when you combine this with the opposite,
but my expectation is that you end up with an empty set, as different facets are combined with AND.
The PR also adds a
nevercombiner option to factets, enforcing that every single facet value mustnot satisfy the facet conditions.