feat: add filtering to card list used for block party. change sort to use highlight and then sort newest first #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use highlight and then sort newest first
shsteimer
changed the title
|
trieloff
approved these changes
Aug 20, 2024
| .filter((row) => row.approved === 'true') | ||
| .reverse() // sort newest entries first, unless highlighted | ||
| .sort((a, b) => { | ||
| if (a.highlight && !b.highlight) return -1; |
There was a problem hiding this comment.
You might get away with something like a.highlight - a.highlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the Cards List block used by block party (and best I can tell, only by block party) to do 2 things:
Related Issue
Motivation and Context
as block party has grown, harder to find things. this makes that easier with minimal impact anywhere else
How Has This Been Tested?
https://card-list-block-party--helix-website--adobe.aem.page/developer/block-party/
https://card-list-block-party--helix-website--adobe.aem.page/docs/ (uses same block but a different variant)
Screenshots (if appropriate):
Types of changes
Checklist: