Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: venn-ish diagram #539

Merged
merged 10 commits into from
Nov 13, 2024
Merged

test: venn-ish diagram #539

merged 10 commits into from
Nov 13, 2024

Conversation

fkakatie
Copy link
Member

@fkakatie fkakatie commented May 31, 2024 •
edited
Loading

Description

https://venn--helix-website--adobe.aem.page/vip/skills

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 31, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 31, 2024 •
edited
Loading

Page Scores Audits Google
📱 /vip/skills Lighthouse returned error: Something went wrong. PSI
🖥️ /vip/skills PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fkakatie fkakatie requested review from kptdobe and amol-anand August 22, 2024 21:15
@fkakatie fkakatie marked this pull request as ready for review August 22, 2024 21:17
@kptdobe kptdobe merged commit 2037329 into main Nov 13, 2024
3 of 4 checks passed
@kptdobe kptdobe deleted the venn branch November 13, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kptdobe kptdobe kptdobe approved these changes

@amol-anand amol-anand Awaiting requested review from amol-anand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkakatie @kptdobe