fix: make suggestions lazier

adobe · Sep 18, 2024 · a96d42e · a96d42e
1 parent 21b2b7b
commit a96d42e
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 24 deletions.
diff --git a/tools/oversight/elements/url-selector.js b/tools/oversight/elements/url-selector.js
@@ -33,7 +33,7 @@ export default class URLSelector extends HTMLElement {
     `;
   }
 
-  async connectedCallback() {
+  connectedCallback() {
     this.innerHTML = this.template;
     const datalist = this.querySelector('datalist');
     const input = this.querySelector('input');
@@ -56,22 +56,25 @@ export default class URLSelector extends HTMLElement {
         }
       });
     } else {
-      const resp = await fetch('https://rum.fastly-aem.page/domains?suggested=true', {
+      fetch('https://rum.fastly-aem.page/domains?suggested=true', {
         headers: {
           accept: 'application/json',
           authorization: `Bearer ${token}`,
         },
-      });
-      if (!resp.ok) {
+      }).then(async (resp) => {
+        if (!resp.ok) {
+          datalist.remove();
+        } else {
+          const { domains } = await resp.json();
+          domains.forEach((domain) => {
+            const option = document.createElement('option');
+            option.value = domain;
+            datalist.appendChild(option);
+          });
+        }
+      }).catch(() => {
         datalist.remove();
-      } else {
-        const { domains } = await resp.json();
-        domains.forEach((domain) => {
-          const option = document.createElement('option');
-          option.value = domain;
-          datalist.appendChild(option);
-        });
-      }
+      });
     }
 
     input.addEventListener('focus', () => {

diff --git a/tools/rum/elements/url-selector.js b/tools/rum/elements/url-selector.js
@@ -33,7 +33,7 @@ export default class URLSelector extends HTMLElement {
     `;
   }
 
-  async connectedCallback() {
+  connectedCallback() {
     this.innerHTML = this.template;
     const datalist = this.querySelector('datalist');
     const input = this.querySelector('input');
@@ -46,22 +46,25 @@ export default class URLSelector extends HTMLElement {
       input.disabled = true;
       datalist.remove();
     } else {
-      const resp = await fetch('https://rum.fastly-aem.page/domains?suggested=true', {
+      fetch('https://rum.fastly-aem.page/domains?suggested=true', {
         headers: {
           accept: 'application/json',
           authorization: `Bearer ${token}`,
         },
-      });
-      if (!resp.ok) {
+      }).then(async (resp) => {
+        if (!resp.ok) {
+          datalist.remove();
+        } else {
+          const { domains } = await resp.json();
+          domains.forEach((domain) => {
+            const option = document.createElement('option');
+            option.value = domain;
+            datalist.appendChild(option);
+          });
+        }
+      }).catch(() => {
         datalist.remove();
-      } else {
-        const { domains } = await resp.json();
-        domains.forEach((domain) => {
-          const option = document.createElement('option');
-          option.value = domain;
-          datalist.appendChild(option);
-        });
-      }
+      });
     }
 
     input.addEventListener('focus', () => {