Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Package generation for JCR pages #459

Open
wants to merge 2 commits into
base: md2jcr
Choose a base branch
from

Conversation

ManasMaji
Copy link
Member

  • Added logic for creating content package using the JCR pages that were generated

// Regex for inline images & reference-style images
// 1. inline images: ![Alt text](url "title")
// 2. reference-style images: ![Alt text][ReferenceLabel]
const imageRegex = /!\[([^\]]*)]\(([^) "]+)(?: *"([^"]*)")?\)|!\[([^\]]*)]\[([^\]]+)]/g;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need to support in richtext.

Copy link
Collaborator

@bhellema bhellema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get this in and iterate on it.

@@ -0,0 +1,79 @@
/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in this file seems to be 4 spaces vs the other files of 2. Actually there's a number of files that have 4 vs 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants