Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asset compute integration test workflow not detecting a successful run #141

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented Feb 6, 2024

Changes

  • Successful deployment grep check removed, there are no deploys in this test - not sure how it passed before
  • Running tests in test/asset-compute/worker grep check modified to use a wildcard for the start of the path - the output contains the full path now
  • Removed unused ffapp folder check (remnant for when it was part of another workflow)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron changed the title fix: asset compute integration test workflow not detecting successful run fix: asset compute integration test workflow not detecting a successful run Feb 6, 2024
@shazron shazron merged commit ccf6a39 into master Feb 6, 2024
5 checks passed
@shazron shazron deleted the fix-asset-compute branch February 6, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants