Make uxp command work again, actually use deps correctly, remove postinstall hooks
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jardicc
reviewed
Jun 7, 2023
| @@ -18,6 +18,7 @@ const { createDeferredPromise } = require("./common"); | |||
|
|
|||
| function getDevtoolsAppExecutablePath() { | |||
| const productName = "Adobe UXP Developer Tool"; | |||
| console.log('hehe') | |||
There was a problem hiding this comment.
Didn't realize I still had this PR open 😄
|
I removed the helper install hook since it doesn't work in CI (on linux), now you have to run: |
|
@jardicc To be honest this whole project needs a lot of work. The code is very messy, error cases are not handled, no types, no build system, it's not following any best practices, no tests at all, not installable on Linux, no documentation on internal UXP apis, etc. It's clear that Adobe doesn't have the bandwidth to work on the DX of developing UXP apps, which makes me a bit sad. I hope this PR can just be a starting point for some Adobe engineers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be tested with
npm i -g @adobe-fixed-uxp/uxp-devtools-cli.