This is a dummy PR to fix #16969 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add custom elements polyfill
…ia#16483) * fixed error for suggestion job * nit * linter
…#16491) * minor improvement * minor ui changes * minor review change * minor review change * minor change * minor change * minor change
* Initial commit * Fixed mypy errors * Addressed comments * minor fix * minor change * Addressed comments * addressed comments and fixed test * Fixed test issues * fixed typescript
…estion (oppia#16481) * Add validation for rte tags in translation html * Fix backend test * Change if clause
…ation (oppia#16352) * trigger stats model update during exp migration * lint error * update method of putting stats * fix mypy errors * refactor * fixes * undo changes to GAE model create method * convert remaining create_and_put -> create * address comments * fix lint check * address comments * address comments * address comments; fix backend tests * address comments and fix mypy errors * address comments * fix backend errors 1 * fix backend errors 2 * fix backend errors 3 * fix backend errors 4 * fix backend errors 5 * fix HasElementXAtPositionY removal logic * fix backend error * fix coverage failures * fix coverage failure (2 lines)
…16457) * initial checks added * continue nit added * tested conversion func * removed id from args * interaction part * added few more checks * end interac * added doc string and RTE checks * few lint fixes * fixed language_code issue * fixed unique and duplicate part * done some changes in unique and duplicate choices * added warning comment * multiple choice fixes * done some suggested changes * made suggested changes * did suggested changes * nit change * nit change * todo comment * added check of item selec for duplicates * nit update for item selec * updation in item selecc * nit * text input * text input updated * text input * made some nits * nit * few changes in interaction * updated interactions * updated the version * did a fix for item selec interac * duplicate rule deletion * few changes in duplicate rule deletion * changed approach of rule duplicates * completed the rule duplication * rte fixes * some formatting change and added some RTE tasks * fixed numeric input interaction * removed non required numeric function * fixed fraction input interaction * fixed item selection input interaction * reomval of unwanted item selec function * several nits changes * edited the drag and drop interaction * edited the text input interaction * few nits * docstring in fetchers file and nit in domain * fixed the rte section * added draft changes and updated rte * nits * nit * made some formatting and backend test fixing * nit change * fixed nit * nit fix * nit * removed binary search yaml file * added back the images * nit in drag * done suggested changes * fixed some tests * nit fix * fixed backend * edited single file * made suggested changes * done suggested changes * fix for the failing backend test * fixed backend and some suggested changes * some basic fix and suggested changes * done suggested changes and backend validation fix * fixed failing backend * fixed few issues * added test * small test nit * fixed the broken code and added the tests for interactions * a small nit * fixed a small nit * added tests * ok to have empty text attribute in link tag * updated * done suggested changes * fixed linter and some suggested changes * done some nit * fixed error for json * added collapsible test * done suggested changes * changed function name * fixed a nit in removal of duplicate rules * added test for continue translation updation part * added test * added tests and a nit * added some test * added some tests for the coverage * addded more tests for the coverage * fixing of invalid exp tags * fixed nit of tabs and collapsible * fixed some mypy type checks * added some backend test * added tests and done some suggested changes * done suggested changes and fixed linting * fixed mypy, lint and done some suggested changes * fixed mypy * fixed backend coverage * fixed last backend coverage * added solution part * indented the code * nit change * made small changes * added rte checks for feedbacks, hints, solution * nit for adding rte check in the drag choices * mypy fix * fix text attr empty in link tag * removed validations that were not required * initial changes * made small nit * nit * added nits * added the part for rejecting the suggestion with invalid id * added the translation RTE updation part * removed unneeded validation * fixed failing validation errors * added the removal of invalid content id * nit * removed unnecessary break * added remaining test * audit * nit audit * removed the validation part and the tags conversion part * added the suggestion migration job * added the audit job and tests * tests * fixed lint and mypy * nit * fixed small nit and suggested comments * updating the voiceovers where needed * done suggested changes * fixed the failing error * fixed the failing test * completed suggested changes * fixed mypy and lint * fixed the failing backend test * a small nit * made changes to exp_migration_job * avoid exp rights for invalid exps * nit required to fix the tests with new changes * fixed linter * small nit for choices * nit change in the choices part * added choices validation and test * suggested nits * lint fix * mypy * empty choices for DragAndDrop * added tests and fixed some part * updated check for emptiness * updated empty choice part and added some validations and their tests * fixed linter * updated the emptiness check a bit * added some tags to emptiness section * generalize some code * updated * completed strict validation * lint * validations will not be called while loading the Question * added one validation and changed stderr to stdout in suggestion job
…checks (oppia#16428) * Curated fixes * Fixed suggestions
* clear cache after updating exp * delete cache for the exp before fetching * address backend test failure * fix mypy error * fix lint errors
* minor improvement * minor ui changes * minor review change * minor review change * minor change * minor change * minor change * minor review chnages
* Allowing 1MB files for blog posts * fixing mypy checks * Fixing lint checks * fixing backend tests * unescaping html * Applying suggestions for blog dashboard * FIxing frontend tests
… Blog Homepage feature. (oppia#16243) * applying suggestions * blog dashboard fixes * backend fixes * backend fixes * backend test fix * backend test fix * author page structure * Applying Suggestions * Fixing linter issues * fixing linter issues * few more changes for blog author page * changing username to author name * increasing test coverage * increasing test coverage * fixing backend tests and coverage * coverage fix backend * fixing descriptions * fixing backend test coverage * fixing covergae * fixing tests * fixing backend coverage and FE tests * fixing qqq string * fixing qqq string * Applying Suggestions * Fixing lint issues * FIxing qqq.json file * FIxing frontend test * Applying suggestions * Applying Suggestions * Applying Suggestions * Self review * Fixing backend test * Applying suggestions and fixing blog post page * fixing linting issues * Applying Suggestions * applying suggestions * Fixing Backend Test * Fixing MyPy checks * Allowing 1MB files for blog posts * fixing mypy checks * Fixing lint checks * fixing backend tests * fixing backend coverage * fixing blog post page * fixing backend test * fixing e2e tests * Applying Suggestions * Applying Suggestions * Applying Suggestions on blog dashboard * Applying Suggestions * Applying Suggestions * Minor nit Co-authored-by: Prayush Dawda <[email protected]>
…uestions handler (oppia#16408) * Adds diagnostic test questions handler * Adds diagnostic test questions API method * Updates API data schema for the diagnostic test skill id to questions * Fixes mypy checks * Fixes typescript check * Fixes lint issue * Fixes backend test * Addresses review comments * Fixes lint issue. * Addresses review comments * Fixes mypy issues * Addresses review comments * Updates handler logic to avoid duplicate questions * Updates backend logic to avoid duplicate questions * Adds backend unit test for coverage * Fixes typo * Updates min question requirement for the diagnostic test skill * Fixes frontend tests * Fixes e2e test * Updates code comments
…ebase. (oppia#16104) * added changes * added fixes and more functionalty * added changes * nits * nits -2 * nits * added changes * commited wrong code for test and proof purpose * fixed code * added changes * added changes * nit
… dialog box (oppia#16232) * material-icons change to font-awesome icons. * ( . )-is-removed * Revert "( . )-is-removed" This reverts commit e1c5ae1. * (.)after-permitted-removed * changes-to-push-remove.issue * intendation-correct * all-intendation-corrected * . after-permitted-removed-from-all-files * unchange-legacy files
…s - 3. (oppia#16473) * added acl_decorator file * added some more files * added backend fixes * minor fixes * added changes * self-review-1 * added blog_homepage * added 2 files * added file * added file * added more files * added more files * added file * added one more file * added new changes for blog homepage * added changes * added one more file * nit * added changes * added changes * added changes * added changes * added changes * added changes * nits * fixed backend coverage * added changes
* Use Cloud Secret * Fix linter * Fix typing * Keep using feconf stuff * Fix mypy * Introduce anonymous creds * Fix MyPy * Fix backend tests * Fix lint issues * Fix tests * Fix backend tests * Partially addressed comments * Modify backend tests * Refactor backend tests * Fix backend tests * Address comments * Return None when secret does not exist * Fix linting * Fix tests
…s - 2. (oppia#16461) * added acl_decorator file * added some more files * added backend fixes * minor fixes * added changes * self-review-1 * added changes * fixed backend coverage -1 * added tests * fixes backend coverage -2 * added more coverage * further increased coverage - 3 * added changes * added changes * added changes * added changes * nits * nits * added comments * added changes * added changes * nits * added changes * added changes * imposed linter * added changes * nits: * nit * implemented generic structure * added changes * added domin_object_validator * added one more file * minor fix * added more files * added changes * added more file * added one more file * added one more file * added changes * added fix * added changes * added changes * added one more file * nits * added nits fixes * added changes * added nits fixes * added more files * nit * added changes * added ben's changes * added changes * vojita's comments * nits * added changes * added changes * minor fi * added changes * fixed backend coverage issue * added changes * nits
…e and blog post page. (oppia#16435)
fixed tag
* Adds diagnostic test player page * Adds html text * Adds frontend unit tests * Adds backend tests * Fixes linter issue * Fixes mypy issues * Fixes typescript checks * Updates copyright text. * Adds diagnostic test model * Alignes diagnostic test player with the question player * Internationalized diagnostic test texts * Adds css rules * Adds Qqq text. * Adds frontend unit tests * Fixes lint issues * Adds test file to the backend shard. * Adds unit test * Fixes lint issues * Fixes lint issues * Fixes typescript issue. * Sort i18n keys * Adds frontend unit test for the diagnostic test model. * Create diagnostic test topic state model * Adds submit and init metods for engine service * Addressed review comments * Updates file docstring + removes extra new line * Adds frontend unit test * Replaces number with a named constant. * Updates UI for the diagnostic page * Removes redundant css class * Loads first card * Adds code comment * Adds diagnostic test topic state model * Adds diagnostic test topic state model * Fixes lint issues. * Adds code comments and unit tests * Renamed variables * Adds code comment * Adds diagnostic test questions handler * Adds diagnostic test questions API method * Renames into diagnostic test topic tracker model * Updates variable name * Fixes lint issues * Updates diagnostic test current topic status model * Fixes lint issues * Updates code comments * Removes type safety check for pop method * Updates API data schema for the diagnostic test skill id to questions * Fixes mypy checks * Fixes typescript check * Fixes lint issue * Fixes backend test * Addresses review comments * Removes unwanted files * Adds submit method * Fixes submit button issue * Adds logic in the conversation skin component * Adds test status service * Addresses review comments * Fixes lint issue. * Addresses review comments * Adds test for the question player status service * Fixes mypy issues * Adds frontend tests * Addresses review comments * Fixes lint and typescript checks * Removes print stamt * Fixes lint and typescript checks * Removes redundant code * Updates handler logic to avoid duplicate questions * Addresses review comments * Adds progress functionality. * Updates backend logic to avoid duplicate questions * Adds backend unit test for coverage * Fixes typo * Updates min question requirement for the diagnostic test skill * Fixes frontend tests * Fixes e2e test * Updates code comments * Fixes UI * Removes conversation skin changes * Removes unwanted changes * Addresses review comments * Adds underscore before fields * Refactors get next question * Addresses review comments * Fixes typescript checks * Fixes lint issue * Addresses review comments * Addresses review comments * Removes blank lines
…navbar. (oppia#16238) * remove nav fixed * correct-linter
…port to detect a stuck learner and provide appropriate assistance. (oppia#16357) * Inital nits for cc. * Init config for concept card service. * temp * service almost done. * Made soln independent. * Init redirection * Minor adds * Work with emitters * Changes * Add support for hint and cc together. * Rediection almost done for learner side. * Support for redirection based on hints+timeout * stuck via incorrect responses. * Refactored * Some changes * Refactored both assistances * Covered exp-footer. * Coverage of cc-ts done * nit * Coverage of convo done * nit * niits * nit fixes * nits * Backend fix * nit * x * Refactor code. * Add condn for showing soln * ui-fixes * nit * changes * Detecting errs * try-2 * try-3 * ft-fix * nit * nit-2 * nit * fixing * ft-nit * nit * trying to fix e2e * try-2 * try-3 * try-4 * try-4 * backend coverage try * backend fix * backend fix * backend fix and ft-cov * Support for soln tooltip * htab fix * fixes * nit * nit * coverage * ft-adds * nit * Changes * coverage done
…pia#16838) * Remove unclear sentence from save progress popup * Remove remaining unclear text and fix broken copy link for save progress * Revert config property change * Fix copy url textbox UI * Fix URL copy CSS
…ppia#17132) * remove interactionId null type fix interaction null type related bugs Fix oppia#16504: Android beta page fixes (oppia#16688) * Android beta page fixes * address comments * fix indentation * fix fe test * address comments * code comments * fix test * fix test * address comments * address comment and fix tests * increase z-index of button so clicks are handled correctly * fix test * fix coverage Fix oppia#16648: Increases tick time to fix debounce frontend test flake (oppia#16958) flake fix FIX#16908 : Submit button in Feedback dialogbox must have layout indicating its a button (oppia#16954) Update feedback-popup.component.html Fix yaml generation (oppia#16921) * Fix yaml generation * Fix indexes * Add tests fix null bug fix bug in constructor fix bug2 interaction id related bug 1 test interaction id bug 1 interaction id null test bug 1 add test coverage recordLearnerAnswer interaction id not null add coverage minor minor minor minor minor minor minor * fix explorationHistoryTab test bug * keep Interaction id null type, remove Answergroup interactionId null type * check interactionObjectfactory interactionId null type minor linter check 1 * delete answergroupobjectfactory null interactionid type * minor * interactionobjectfactory createfrombackenddict interactionId only string * minor * parameter-metadata service test interaction id is not null * minor * minor * minor check * parameter-metadata.service get unset parameters info test interactionId not null * linter check * linter check * minor * exploration-warnings service test remove answergroup
* initial code * initial changes for read file * nit * added print to debug * attempt to test the changes of GCS * attempt to test the changes on GCS * test job and changes to gcs_io * nits * basic * updates to req file * fixed some mypy * updated tests * nit * added print statements for debugging * fixed gcsio test * recovered req file * nit update * fixed linter * initial changes * added write file part * add webptools * started audit job * updated tests * audit job to fetch user images * added for DeleteFile * added getfiles part * nit * lint * done suggested changes and lint fixing * updates as per comments * reqs file update * added test file and done suggested changes * fixed mypy and coverage * lint * added the audit job and tests also done suggested changes * moved gcs initializer back to function * updated * fixed coverage, lint and mypy * not edit to env part * done suggested changes * coverage complete * mypy * replaced the gcs io implementation * done suggested changes * suggested changes and the failing backend test * suggested changes * lint * done with the suggested changes * lint * mypy * added 'assets' to the filepath * added the suggested changes * lint * mypy * nit * removed test jobs and nit updates * nit update * added jobs to registry file * updated the migration job to fix invalid images * some updates in audit * updated the audit job * added one more test * nits
…ion dialog box fixed. (oppia#16955) * fixing the draggable property * linting fix * removing the comment from code * removing inline styling * updated to a more descriptive class * textbox on preferences pg css added --------- Co-authored-by: Kamal Singh <[email protected]>
…title validation and also fixes other bugs (oppia#17018) * Fixing issues * Fixing issues * Fixing issues * Fixing issues * blog fixes * fixes * fix linting issues * fix comment * fixing lint issues * Update core/templates/services/stateful/focus-manager.service.spec.ts Co-authored-by: Jay Vivarekar <[email protected]> * adding blog post title handler * final changes * fixing lint issues * fix blocking bugs * fix frontend tests * fix frontend coverage * fixing backend tests * applying suggestions * fixing lint issues * fixing backend test * Applying suggestions and fixing backend tests * Applying suggestions * Applying Suggestions * Applying Suggestions * Applying Suggestions * applying suggestions --------- Co-authored-by: Jay Vivarekar <[email protected]> Co-authored-by: Shivkant Chauhan <[email protected]>
* add q-a-installation.yml * address comments * address comments
* Fixed oppia#17206 added span tag with underline class * removed unwanted white space around the span tag in line 183 * Added Underline on hover for Basic Mathematics * removed unwanted white spaces present around span tag in line 109 * removed trailing white spaces present in line 109
* removed the WHO link from OPPIA Avatar * removed WHO link * first commit * first commit * removed WHO Link * revised changes * done changes * changes * revised changes * revised changes * revised changes * revised changes * revised changes * revised changes * rerun tests * revised changes * revised changes * revised changes * revised changes * revised changes
* added underline class and tabindex for tab focus and changed div to a * changed div tag to a tag bcz it was highlighted with box and it was semantically correct * corrected the allingment of anchor tag and its attributes on line 107-108 * corrected the allingment of anchor tag and its attributes on line 107-109 * Resolved the Merge Conflict by removing the extra space
…stion (oppia#17257) * Revised changes from previous PR * failing tests * failing tests * failing tests * failing tests * failing tests * failing tests * Changes made that were requested by sean * lint errors * ts errors * unit tests * unit tests * Made changes requested by reviewer
…ptance-tests (oppia#17225) * added super-admin-utils class * addressed comment by Sean * addressed Sean comment about Pop up dialog * removed learner-dashboard constant * changed class name ( puppeteerUtilities -> baseUser ) * added commented link for event 'dialog' * addressed Sean comments --------- Co-authored-by: Shivkant Chauhan <[email protected]>
* Combined audit and exploration migration jobs * Combined audit and exploration migration jobs * Create a transform for exp migration * fix lint errors * Address review comments * Fix lint errors * Address review comments * Fix lint errors * Address review comments * Address review comments * Address review comments * fix lint errors * fix lint errors * Fake migration commit * Fix backend errors * Remove fake migration changes
* TanyaAgarwal28-issue-17251 * TanyaAgarwal28-issue-17251
…ight position in music play exploration (oppia#17352) Update music_notes_input.css
…#16935) * Replaced icons in settings tab * solved the grayout issue --------- Co-authored-by: Akshay Anand <[email protected]>
…ns in topic-editor-page (oppia#17170) * Replaced material icons with FA icons * CSS to fix FA icons * Fix lint errors * Fix FA icons with CSS * Fix Workflow * Fix Lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Essential Checklist
Proof that changes are correct
PR Pointers