Skip to content

Commit

Permalink
Removed manual newline character (platform independent) and commented…
Browse files Browse the repository at this point in the history
… out pid higher test which is not always true
  • Loading branch information
shlomohass committed Feb 7, 2023
1 parent 3165644 commit d7b325b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/Helper/ShellTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function test_get_output()

$shell->execute();

$this->assertSame("hello\n", $shell->getOutput());
$this->assertSame("hello", trim($shell->getOutput())); // trim to remove trailing newline which is OS dependent
$this->assertSame(0, $shell->getExitCode());
}

Expand All @@ -35,7 +35,7 @@ public function test_get_process_id()
$shell->execute(true);

$this->assertIsInt($pid = $shell->getProcessId());
$this->assertGreaterThan(getmypid(), $pid);
// $this->assertGreaterThan(getmypid(), $pid); // this is not always true especially on windows
}

public function test_async_stop()
Expand Down

0 comments on commit d7b325b

Please sign in to comment.