Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given&Then has been added to ZB. #504

Merged
merged 5 commits into from
Dec 28, 2023
Merged

Conversation

nkarmazina
Copy link
Collaborator

The following has been changed:

  1. The "add block as reference" checkbox & "Add Block" button are deactivated, if no block is selected.
  2. The dropDown selection is added, if the "add block as reference" is checked. "When" selected by default.
  3. Added id to reference block as a step.

The following has been changed:
1) The "add block as reference" checkbox & "Add Block" button are deactivated, if no block is selected.
2) The dropDown selection is added, if the "add block as reference" is checked. "When" selected by default.
3) Added id to reference block as a step.
@nkarmazina nkarmazina requested a review from Alice-cla December 11, 2023 11:02
frontend/src/app/base-editor/base-editor.component.html Outdated Show resolved Hide resolved
frontend/src/app/base-editor/base-editor.component.ts Outdated Show resolved Hide resolved
@@ -152,6 +165,11 @@ td.mat-mdc-cell:first-of-type, td.mat-mdc-footer-cell:first-of-type{
background: #90CAF9;
}

::ng-deep .mat-mdc-form-field.wayToAddBlockDropDown .mat-mdc-select-value-text {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geht vielleicht ohne ng-deep?

display: flex;
align-items: center;
}
::ng-deep .wayToAddBlockDropDown .mat-mdc-form-field-infix{
Copy link
Collaborator

@Alice-cla Alice-cla Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die css Klasse ist schon in styles vorhanden. Möglicherweise geht es deshalb nicht, die Klasse im Component css zu überschreiben.
image
Vielleicht macht es Sinn, die vielen padding-Values zu reviewen und ggf. anpassen.

display: flex;
align-items: center;
}
::ng-deep .wayToAddBlockDropDown .mat-mdc-form-field-infix{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.wayToAddBlockDropDown - vielleicht umbenennen, sodass es klar ist, auf welches Element es sich betrifft.

display: flex;
align-items: center;
}
.wayToAddBlock{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.wayToAddBlock - vielleicht umbenennen, sodass es klar ist, auf welches Element es sich betrifft.

@nkarmazina nkarmazina force-pushed the CUC-533-given-then-in-central-block branch from 54da9c0 to f76f40c Compare December 28, 2023 13:48
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Alice-cla Alice-cla merged commit 3aea89b into dev Dec 28, 2023
2 checks passed
@i3rotlher i3rotlher deleted the CUC-533-given-then-in-central-block branch March 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants