-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new component #241
adding new component #241
Conversation
Thanks @MartinEbnerSensirion, I had planned to look at this over the holidays! |
Yeah totally! I've been waiting for this combined sensor for 18months 😁 so grabbed one immediately, but had too much to finish before the end of the year and it seemed a bit cheeky to prioritise my new sensor when it wasn't available in mass production yet (except the one eval kit model). Didn't stop me starting looking at the Circuitpython port though (did the sen5x last time), but it's shifted dependency to a type heavy repo so more work / verification needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you
@MartinEbnerSensirion this'll be merged once there's a corresponding PR for the driver (and I'll approve the PR for CI builds for testing). Feel free to have a go (or I'll take it on at some point), and as mentioned you can change the string match of sen55 and then initialisation call, to instead do the sen66 (in src/components/i2c/wippersnapper_i2c), also adding your library requirements to library.properties and platformio.ini (assuming its in arduino library registry which it is - otherwise also the driver git repo to ci build step). |
I see the pr coming along, lets merge this now so we can play sooner |
@tyeth appreciate it, thanks! |
No description provided.