Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new component #241

Merged
merged 4 commits into from
Dec 22, 2024
Merged

adding new component #241

merged 4 commits into from
Dec 22, 2024

Conversation

MartinEbnerSensirion
Copy link
Contributor

No description provided.

@tyeth
Copy link
Contributor

tyeth commented Dec 22, 2024

Thanks @MartinEbnerSensirion, I had planned to look at this over the holidays!
I've got one of these to test, but we'll need the matching driver in the firmware repo too. For now you can fake it by taking over the sen55 driver wrapper and ignoring the old or hard coding the new i2c address in begin

@MartinEbnerSensirion
Copy link
Contributor Author

@tyeth matching drivers should be quite low-friction as there's a almost 100% compatible repo here

@tyeth
Copy link
Contributor

tyeth commented Dec 22, 2024

Yeah totally! I've been waiting for this combined sensor for 18months 😁 so grabbed one immediately, but had too much to finish before the end of the year and it seemed a bit cheeky to prioritise my new sensor when it wasn't available in mass production yet (except the one eval kit model). Didn't stop me starting looking at the Circuitpython port though (did the sen5x last time), but it's shifted dependency to a type heavy repo so more work / verification needed

components/i2c/sen66/definition.json Outdated Show resolved Hide resolved
Copy link
Contributor

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@tyeth
Copy link
Contributor

tyeth commented Dec 22, 2024

@MartinEbnerSensirion this'll be merged once there's a corresponding PR for the driver (and I'll approve the PR for CI builds for testing). Feel free to have a go (or I'll take it on at some point), and as mentioned you can change the string match of sen55 and then initialisation call, to instead do the sen66 (in src/components/i2c/wippersnapper_i2c), also adding your library requirements to library.properties and platformio.ini (assuming its in arduino library registry which it is - otherwise also the driver git repo to ci build step).
If you do want to work on it and would like this merged for ease of development then do say.

@tyeth
Copy link
Contributor

tyeth commented Dec 22, 2024

I see the pr coming along, lets merge this now so we can play sooner

@tyeth tyeth merged commit 4236b58 into adafruit:main Dec 22, 2024
13 checks passed
@MartinEbnerSensirion
Copy link
Contributor Author

@tyeth appreciate it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants