Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous enabled #30

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

s-light
Copy link

@s-light s-light commented Aug 7, 2019

let user decide if sensor should run continuously or only on interaction.
(default: maintains old behavior = enable only on interaction)

so for the new 'continuously on mode' you have to enable it after the begin call:

if (tsl.begin()) {
    Serial.println(F("Found a TSL2591 sensor"));
    // if you want faster (non delaying) responses enable the sensor continuously:
    // (this needs more power..)
    tsl.enable();
}

should be fixing most things requested in #12
and all basics of #27

@s-light
Copy link
Author

s-light commented Aug 7, 2019

also should fix main part of #27

@ladyada ladyada requested a review from hoffmannjan August 7, 2019 21:54
Copy link
Contributor

@hoffmannjan hoffmannjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good for me but don't have chip to test, can buy locally @ladyada

@s-light
Copy link
Author

s-light commented Aug 8, 2019

thanks Jan for the review!

i have not looked into the failing Travis CI logs -
but will try to fix this tomorrow so that travis is also happy..

i have spliced the whitespace-only things into a separate (earlier) pull-request (#28) so that it is easier to see what is changed...
so would make sens to merge this first if you like this idea.

i also have another pull-request in the making for some interruppt/threshold things: extended interrupt tests & small api extension
(https://github.com/s-light/Adafruit_TSL2591_Library/tree/add_NPAI) - this will take one or two days until i have it done...

@s-light
Copy link
Author

s-light commented Aug 9, 2019

thanks @hoffmannjan for the travis fix.

@s-light s-light mentioned this pull request Oct 21, 2019
@s-light
Copy link
Author

s-light commented Jan 20, 2020

i have cleaned the library.properties conflict..
this way currently the version is not updated..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants