Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes for add-url-pattern #800

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Dec 7, 2024

This is a minor fix for @anonrig's add-url-pattern. Mostly, we use a friend template instead of a friend function and we avoid unnecessary forward references by switching the include order.

@lemire lemire requested a review from anonrig December 7, 2024 23:15
@anonrig anonrig merged commit 964423a into yagiz/add-url-pattern Dec 8, 2024
23 of 25 checks passed
@anonrig anonrig deleted the lemire/add-url-pattern-fixes branch December 8, 2024 00:11
anonrig pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants