Weather Report - HW - Sea Turtles #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jun 18, 2022
| <body> | ||
|
|
||
| <div>Weather Report</div> | ||
| <main> | ||
| <section> |
There was a problem hiding this comment.
good job using sections and other semantic HTML Here is a resource to show you when to use particular tags
| 'https://images.unsplash.com/photo-1584267385494-9fdd9a71ad75?ixlib=rb-1.2.1&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=2670&q=80', | ||
| }; | ||
|
|
||
| const domElements = { |
There was a problem hiding this comment.
adding your domElements here is a good way to organize your file
| domElements.currentTemp.textContent = state.temperature; | ||
| }, | ||
| tempBackgroundChange: (backgroundColor, landscape) => { | ||
| console.log(backgroundColor); |
| return Math.floor(1.8 * (kelvin - 273) + 32) | ||
|
|
||
| } | ||
| const setBackgroundColorLandscape = (temperature) => { |
| } | ||
| }; | ||
|
|
||
| const setSkyImage = (skyCondition) => { |
| }; | ||
|
|
||
| // const axios = require('axios'); | ||
| const getLatitudeLongitude = async () => { |
There was a problem hiding this comment.
I would move your api functions before registering your event handlers just to put them all together with the other functions
| @@ -0,0 +1,65 @@ | |||
| body { | |||
There was a problem hiding this comment.
I know we talked about using the grid to overlap elements. Here is a resource to do that https://www.joomlashack.com/blog/tutorials/layering-items-within-css-grid/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to close previous pull request. Wrong branch and some issues tracking some missing code. Still trouble-shooting a bit but everything seems to be here for the most part.